fix: enforce strict CAD showcase delivery gates
This commit is contained in:
19
SKILL.md
19
SKILL.md
@@ -15,6 +15,7 @@ Produce an evidence-backed architectural showcase, not a blind CAD conversion. D
|
||||
- overview/standard/detail GLBs plus metadata;
|
||||
- Blender scene/preview when Blender is selected;
|
||||
- served Web viewer and/or offline single-file viewer;
|
||||
- `scope_manifest.json` accounting for every requested building and the site;
|
||||
- `evidence_manifest.json` with machine-readable final checks;
|
||||
- notes stating assumptions, missing geometry, source limitations, and confidence level.
|
||||
|
||||
@@ -44,6 +45,7 @@ Read only the branches needed for the current task:
|
||||
- Use standard line extraction for architectural DWG/DXF plans.
|
||||
- Use `detect_sheet_frames.py` for multi-frame sheets.
|
||||
- Model each building separately before campus assembly.
|
||||
- For multi-building/campus requests, write `scope_manifest.json` before modeling. Copy every requested building ID from the user/source inventory; never shrink scope to the easiest drawing set.
|
||||
- Use `--converter oda` plus `extract_3d_solids.py` for known 3DSOLID/ACIS drawings.
|
||||
- Stop and request DWG/DXF/vector conversion for PDF-only input.
|
||||
|
||||
@@ -57,12 +59,13 @@ Read only the branches needed for the current task:
|
||||
`python3 scripts/cad_showcase.py run --dxf-dir <dxf> --config <config> --source-report <cad_read_report.json> --out-dir <out> --name <name> --frames <frames.json> --backend trimesh`.
|
||||
- Use `--backend blender` when `.blend` and Blender preview are required.
|
||||
- Never pass `--no-strict-gates` to proceed toward delivery.
|
||||
- Treat audit `WARN` and `SKIP` as `BLOCKED`, not success. Continue only with an explicit `--waiver 'audit:<gate>=<evidence-based reason>'`; retain it in final evidence.
|
||||
- Open the SVG overlays. Iterate if red/unclassified geometry forms walls, glazing, columns, beams, grids, stairs, slabs, roofs, or whole building wings.
|
||||
|
||||
5. Verify actual deliverables.
|
||||
- Require `verify_showcase.py --strict` and `verify_delivery.py` to pass.
|
||||
- Inspect at least one iso/front/side/plan render personally.
|
||||
- For served Web output, run `web_smoke_test.mjs` at desktop and 390px widths and feed its report to `verify_delivery.py --browser-report`.
|
||||
- For served Web output, use `cad_showcase.py run --web`; it starts a temporary local server, runs `web_smoke_test.mjs` at desktop and 390px widths, and feeds the report to final verification automatically.
|
||||
- Confirm idle `window.__renders` does not grow, GLBs decode, variants exist, controls work, and console errors are zero.
|
||||
|
||||
6. Report confidence and limits.
|
||||
@@ -77,12 +80,13 @@ Do not hand over a model unless every applicable item has evidence:
|
||||
2. Config and spec pass their versioned JSON Schemas.
|
||||
3. Every configured source exists, every floor key is unique, every floor is nonempty, and `floor_order` has no gaps/ghosts.
|
||||
4. Multi-frame projects pass `frame_ledger`; every detected plan frame is used or appears in `discarded_frames` with a reason.
|
||||
5. Audit exits 0 and all required gates pass: source presence, floor uniqueness/nonempty, floor alignment/cross-floor datum, glazing capture, annotation exclusion, declared areas, and storey count when armed.
|
||||
5. Audit exits 0 and every gate is `PASS`; `WARN`/`SKIP` block delivery unless a named, reasoned waiver is recorded in evidence.
|
||||
6. Derive emits no `WARNING topless_group`; GLB build emits no `WARNING mesh_from_polygons`.
|
||||
7. Campus output has proven transforms, no unexplained overlap, numeric neighbour gaps, boundary containment, and a top-view placement image.
|
||||
8. `verify_delivery.py` writes `evidence_manifest.json` with overall `PASS`; a human has looked at the render.
|
||||
9. Served Web delivery includes a passing browser smoke report when the environment permits browser testing.
|
||||
10. After any script/schema/template change, run:
|
||||
7. Campus output has a `scope_manifest.json` containing every requested building. Every building and the site is `PASS`, with existing artifacts; a `BLOCKED` entry means the campus request is not complete.
|
||||
8. Campus output has proven transforms, no unexplained overlap, numeric neighbour gaps, boundary containment, and a top-view placement image.
|
||||
9. `verify_delivery.py` writes `evidence_manifest.json` with overall `PASS`; `BLOCKED`/`FAIL` must never be described as complete, and a human has looked at the render.
|
||||
10. Served Web delivery includes a passing desktop/mobile browser smoke report. If Chromium cannot run, report `BLOCKED`; do not substitute the offline viewer for the requested Web template.
|
||||
11. After any script/schema/template change, run:
|
||||
- `pytest tests/test_contracts.py tests/test_delivery.py`
|
||||
- `python3 tests/test_extraction_pipeline.py`
|
||||
- `ruff format --check scripts tests && ruff check scripts tests`
|
||||
@@ -113,7 +117,7 @@ python3 scripts/cad_showcase.py run \
|
||||
--source-report outputs/<project>/cad_read_report/cad_read_report.json \
|
||||
--frames work/<project>/frames_config.json \
|
||||
--out-dir outputs/<project> --name <project> \
|
||||
--backend trimesh --web --offline --resume
|
||||
--backend trimesh --web --offline --scope-manifest work/<project>/scope_manifest.json --resume
|
||||
```
|
||||
|
||||
For a known ACIS/3DSOLID source, force ODA during inspection; do not let an apparently nonempty libredwg conversion hide dropped solids:
|
||||
@@ -131,6 +135,7 @@ python3 scripts/extract_3d_solids.py \
|
||||
- Prefer stable layered geometry over overfitted CAD noise.
|
||||
- Preserve floor/category naming as `<floor_key>__<category>` and glTF Y-up.
|
||||
- Keep source originals unchanged; write intermediates under `work/` and deliveries under `outputs/`.
|
||||
- Start each independent attempt in a new project directory. Reusing a prior directory requires an explicit user request and a recorded provenance note.
|
||||
- Use CAD-derived footprint polygons for slabs/roofs when evidence is sufficient; do not present generated caps, hulls, mullions, wall unions, or massings as BIM-verified geometry.
|
||||
- Keep slabs visible for presentation, grids/details toggleable, and in-scene labels off by default.
|
||||
- Never claim rooms, openings, quantities, materials, MEP coordination, code compliance, or production BIM unless the IFC branch explicitly generates and validates them.
|
||||
|
||||
Reference in New Issue
Block a user