fix: enforce strict CAD showcase delivery gates
This commit is contained in:
@@ -3,10 +3,11 @@
|
||||
## Contents
|
||||
|
||||
1. Branch selection
|
||||
2. Placement evidence
|
||||
3. Site outlines and missing buildings
|
||||
4. Assembly gates
|
||||
5. Site context
|
||||
2. Scope contract
|
||||
3. Placement evidence
|
||||
4. Site outlines and missing buildings
|
||||
5. Assembly gates
|
||||
6. Site context
|
||||
|
||||
## Branch Selection
|
||||
|
||||
@@ -14,6 +15,25 @@ Treat folders such as `1#厂房 / 2#厂房 / 3#辅房 / 总图` as a campus, not
|
||||
|
||||
Building plans are usually millimeters; total/site plans may be meters at surveying coordinates. Never combine both in one extraction config. Convert everything to site-local meters before GLB export; raw coordinates hundreds of kilometers from origin lose float32 precision.
|
||||
|
||||
## Scope Contract
|
||||
|
||||
Before modeling, write `scope_manifest.json` from the user request and source inventory. Do not derive requested scope from whichever config or GLB happened to succeed. Minimum shape:
|
||||
|
||||
```json
|
||||
{
|
||||
"scope_version": 1,
|
||||
"mode": "campus",
|
||||
"requested": ["1#", "2#", "3#"],
|
||||
"buildings": [
|
||||
{"id": "1#", "status": "PASS", "artifacts": ["outputs/1/model.glb"]},
|
||||
{"id": "2#", "status": "BLOCKED", "reason": "unresolved XREF", "artifacts": []}
|
||||
],
|
||||
"site": {"status": "PASS", "artifacts": ["outputs/site_top.png", "outputs/site_manifest.json"]}
|
||||
}
|
||||
```
|
||||
|
||||
Every `requested` ID must have exactly one ledger entry. `PASS` requires at least one existing non-empty artifact. `BLOCKED` requires a concrete reason and makes the overall campus result `BLOCKED`, not complete. The campus site must likewise be `PASS` with artifacts. Feed the ledger to `cad_showcase.py run --scope-manifest ...` or `verify_delivery.py --scope-manifest ...`.
|
||||
|
||||
## Placement Evidence
|
||||
|
||||
Prefer anchors in this order:
|
||||
|
||||
@@ -36,7 +36,7 @@ The offline viewer intentionally follows an older Three API. Keep its vendored l
|
||||
|
||||
## Browser Smoke Test
|
||||
|
||||
Serve the Web directory locally, then run:
|
||||
`cad_showcase.py run --web` performs this gate automatically. For a manual/custom delivery, serve the Web directory locally, then run:
|
||||
|
||||
```bash
|
||||
node scripts/web_smoke_test.mjs \
|
||||
@@ -45,7 +45,9 @@ node scripts/web_smoke_test.mjs \
|
||||
--screenshots-dir outputs/<project>/browser_smoke
|
||||
```
|
||||
|
||||
Install Playwright/Chromium first when needed. The script checks desktop/mobile control visibility, console/page/request failures, and idle render behavior. Feed the report to final verification with `--browser-report`; use `--require-browser-report` for formal Web delivery.
|
||||
Install Playwright/Chromium first when needed. The script checks desktop/mobile control visibility, console/page/request failures, and idle render behavior. Feed the report to final verification with `--browser-report`. Supplying `--web-dir` makes the report mandatory: no report is `BLOCKED`, never PASS.
|
||||
|
||||
When an execution tool already has a `run_in_background` option, launch `python3 -m http.server ...` as the foreground command of that background process. Do not append shell `&`; the child server can die with the wrapper. Before presenting the viewer, probe the URL and keep that server process alive. Present the formal `web/index.html` URL when Web was requested; `viewer.html` is a separate offline fallback, not a substitute.
|
||||
|
||||
## Strict Evidence Manifest
|
||||
|
||||
@@ -64,4 +66,4 @@ python3 scripts/verify_delivery.py \
|
||||
--evidence-out outputs/<project>/evidence_manifest.json
|
||||
```
|
||||
|
||||
The verifier checks schema versions, GLB headers/mesh structure/naming/budgets, render dimensions/nonblank variance, Web assets/placeholders/features/variants, offline payload, and browser report. Treat overall FAIL as a delivery blocker.
|
||||
The verifier checks schema versions, audit gates, optional campus scope, GLB headers/mesh structure/naming/budgets, render dimensions/nonblank variance, Web assets/placeholders/features/variants, offline payload, and browser report. Only overall `PASS` is complete. `WARN`/`SKIP` produce overall `BLOCKED` unless the exact check has an explicit `--waiver 'CHECK=REASON'`; `FAIL` cannot be waived.
|
||||
|
||||
Reference in New Issue
Block a user