fix: close remaining CAD delivery review gaps
This commit is contained in:
@@ -16,6 +16,7 @@ from pathlib import Path
|
||||
from typing import Any
|
||||
|
||||
import showcase_schema
|
||||
from delivery_waivers import apply_waivers, parse_waivers
|
||||
|
||||
|
||||
def sha256(path: Path) -> str:
|
||||
@@ -30,48 +31,6 @@ def add_check(checks: list[dict[str, Any]], name: str, status: str, detail: str,
|
||||
checks.append({"name": name, "status": status, "detail": detail, **data})
|
||||
|
||||
|
||||
def parse_waivers(values: list[str]) -> dict[str, str]:
|
||||
"""Parse explicit CHECK=REASON waivers.
|
||||
|
||||
Waivers are deliberately verbose: an Agent cannot silently turn WARN/SKIP
|
||||
into PASS, and a misspelled or unused waiver becomes a hard failure.
|
||||
"""
|
||||
waivers: dict[str, str] = {}
|
||||
for value in values:
|
||||
name, separator, reason = value.partition("=")
|
||||
name = name.strip()
|
||||
reason = reason.strip()
|
||||
if not separator or not name or not reason:
|
||||
raise ValueError(f"Invalid waiver {value!r}; expected CHECK=REASON")
|
||||
if name in waivers:
|
||||
raise ValueError(f"Duplicate waiver for {name!r}")
|
||||
waivers[name] = reason
|
||||
return waivers
|
||||
|
||||
|
||||
def apply_waivers(checks: list[dict[str, Any]], waivers: dict[str, str]) -> None:
|
||||
used: set[str] = set()
|
||||
for check in checks:
|
||||
name = str(check["name"])
|
||||
if name not in waivers:
|
||||
continue
|
||||
used.add(name)
|
||||
if check["status"] not in {"WARN", "SKIP"}:
|
||||
add_check(
|
||||
checks,
|
||||
f"waiver:{name}",
|
||||
"FAIL",
|
||||
f"Waivers may only acknowledge WARN/SKIP checks; {name} is {check['status']}",
|
||||
)
|
||||
continue
|
||||
check["original_status"] = check["status"]
|
||||
check["status"] = "PASS"
|
||||
check["waiver_reason"] = waivers[name]
|
||||
check["detail"] = f"WAIVED ({waivers[name]}): {check['detail']}"
|
||||
for name in sorted(set(waivers) - used):
|
||||
add_check(checks, f"waiver:{name}", "FAIL", f"Unused or misspelled waiver: {name}")
|
||||
|
||||
|
||||
def inspect_glb(path: Path, budget_mb: float, checks: list[dict[str, Any]]) -> dict[str, Any] | None:
|
||||
if not path.exists() or path.stat().st_size == 0:
|
||||
add_check(checks, f"glb:{path.name}", "FAIL", f"Missing or empty GLB: {path}")
|
||||
@@ -210,11 +169,11 @@ def inspect_web(web_dir: Path, checks: list[dict[str, Any]]) -> None:
|
||||
)
|
||||
try:
|
||||
metadata = json.loads((web_dir / "model_metadata.json").read_text(encoding="utf-8"))
|
||||
missing_variants = [
|
||||
item.get("file", "?")
|
||||
for item in metadata.get("model_variants", [])
|
||||
if not (web_dir / item.get("file", "")).exists()
|
||||
]
|
||||
missing_variants = []
|
||||
for item in metadata.get("model_variants", []):
|
||||
file_name = item.get("file")
|
||||
if not isinstance(file_name, str) or not file_name or not (web_dir / file_name).is_file():
|
||||
missing_variants.append(file_name or "<missing file>")
|
||||
add_check(
|
||||
checks,
|
||||
"web:variants",
|
||||
|
||||
Reference in New Issue
Block a user