security(P0③ followup): 关 TodoController advanced-script 生产 RCE
/api/workflow/process/{id}/advanced-script 执行请求体 Groovy,原无 @Profile/无角色门=任意认证用户 prod RCE(独立安全评审揪出的 ScriptExecuteController 孪生)。注入 Environment + SecurityProfiles.isBypassActive 守卫:严格 profile 直接 amisFail 不执行脚本。
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -29,7 +29,10 @@ import org.springframework.web.bind.annotation.RequestBody;
|
|||||||
import org.springframework.web.bind.annotation.RequestParam;
|
import org.springframework.web.bind.annotation.RequestParam;
|
||||||
import org.springframework.web.bind.annotation.RestController;
|
import org.springframework.web.bind.annotation.RestController;
|
||||||
|
|
||||||
|
import org.springframework.core.env.Environment;
|
||||||
|
|
||||||
import com.eip4.platform.auth.security.AuthPrincipal;
|
import com.eip4.platform.auth.security.AuthPrincipal;
|
||||||
|
import com.eip4.platform.auth.security.SecurityProfiles;
|
||||||
import com.eip4.platform.flowgateway.aggregate.BusinessSummaryService;
|
import com.eip4.platform.flowgateway.aggregate.BusinessSummaryService;
|
||||||
import com.eip4.platform.flowgateway.aggregate.TodoAggregator;
|
import com.eip4.platform.flowgateway.aggregate.TodoAggregator;
|
||||||
import com.eip4.platform.flowgateway.aggregate.TodoItem;
|
import com.eip4.platform.flowgateway.aggregate.TodoItem;
|
||||||
@@ -77,15 +80,18 @@ public class TodoController {
|
|||||||
private final StatusWriteback statusWriteback;
|
private final StatusWriteback statusWriteback;
|
||||||
private final BusinessSummaryService businessSummaryService;
|
private final BusinessSummaryService businessSummaryService;
|
||||||
private final JdbcTemplate jdbcTemplate;
|
private final JdbcTemplate jdbcTemplate;
|
||||||
|
/** P0:判定是否处于非生产旁路 profile,用于关闭生产环境的任意脚本执行端点。 */
|
||||||
|
private final Environment environment;
|
||||||
|
|
||||||
public TodoController(TodoAggregator todoAggregator, FlowableClient flowableClient,
|
public TodoController(TodoAggregator todoAggregator, FlowableClient flowableClient,
|
||||||
StatusWriteback statusWriteback, BusinessSummaryService businessSummaryService,
|
StatusWriteback statusWriteback, BusinessSummaryService businessSummaryService,
|
||||||
JdbcTemplate jdbcTemplate) {
|
JdbcTemplate jdbcTemplate, Environment environment) {
|
||||||
this.todoAggregator = todoAggregator;
|
this.todoAggregator = todoAggregator;
|
||||||
this.flowableClient = flowableClient;
|
this.flowableClient = flowableClient;
|
||||||
this.statusWriteback = statusWriteback;
|
this.statusWriteback = statusWriteback;
|
||||||
this.businessSummaryService = businessSummaryService;
|
this.businessSummaryService = businessSummaryService;
|
||||||
this.jdbcTemplate = jdbcTemplate;
|
this.jdbcTemplate = jdbcTemplate;
|
||||||
|
this.environment = environment;
|
||||||
}
|
}
|
||||||
|
|
||||||
@Operation(summary = "当前用户待办(含候选组待办)",
|
@Operation(summary = "当前用户待办(含候选组待办)",
|
||||||
@@ -276,12 +282,20 @@ public class TodoController {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Operation(summary = "流程监控高级处理脚本",
|
@Operation(summary = "流程监控高级处理脚本",
|
||||||
description = "流程监控页专用:按老系统语义给 Groovy 绑定 processid/businessKey 后执行;失败返回 AMIS status=1。")
|
description = "流程监控页专用:按老系统语义给 Groovy 绑定 processid/businessKey 后执行;失败返回 AMIS status=1。"
|
||||||
|
+ "【仅非生产旁路 profile 可用:本端点执行请求体里的任意 Groovy(RCE),生产已禁用。】")
|
||||||
@PostMapping("/api/workflow/process/{processInstanceId}/advanced-script")
|
@PostMapping("/api/workflow/process/{processInstanceId}/advanced-script")
|
||||||
public ResponseEntity<Map<String, Object>> runProcessAdvancedScript(
|
public ResponseEntity<Map<String, Object>> runProcessAdvancedScript(
|
||||||
@AuthenticationPrincipal AuthPrincipal principal,
|
@AuthenticationPrincipal AuthPrincipal principal,
|
||||||
@PathVariable String processInstanceId,
|
@PathVariable String processInstanceId,
|
||||||
@RequestBody(required = false) GatewayRequests.AdvancedScriptRequest req) {
|
@RequestBody(required = false) GatewayRequests.AdvancedScriptRequest req) {
|
||||||
|
// P0 安全(2026-06-24 架构评审 followup,安全评审揪出的 ScriptExecuteController 孪生实例):
|
||||||
|
// 本端点执行请求体携带的任意 Groovy(= 远程代码执行 RCE),严禁在生产可达。
|
||||||
|
// 仅 dev/local/ci/parity 旁路 profile 放行;严格(prod/默认)profile 直接拒绝,绝不执行脚本。
|
||||||
|
if (!SecurityProfiles.isBypassActive(environment)) {
|
||||||
|
return ResponseEntity.ok(amisFail(
|
||||||
|
"流程高级处理脚本仅在非生产环境可用(生产已禁用任意脚本执行)"));
|
||||||
|
}
|
||||||
String script = req == null ? null : trim(req.script);
|
String script = req == null ? null : trim(req.script);
|
||||||
if (script == null || script.isBlank()) {
|
if (script == null || script.isBlank()) {
|
||||||
return ResponseEntity.ok(amisFail("请输入高级处理脚本"));
|
return ResponseEntity.ok(amisFail("请输入高级处理脚本"));
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import static org.assertj.core.api.Assertions.assertThat;
|
|||||||
import static org.mockito.ArgumentMatchers.anyString;
|
import static org.mockito.ArgumentMatchers.anyString;
|
||||||
import static org.mockito.ArgumentMatchers.any;
|
import static org.mockito.ArgumentMatchers.any;
|
||||||
import static org.mockito.Mockito.mock;
|
import static org.mockito.Mockito.mock;
|
||||||
|
import static org.mockito.Mockito.never;
|
||||||
import static org.mockito.Mockito.verify;
|
import static org.mockito.Mockito.verify;
|
||||||
import static org.mockito.Mockito.when;
|
import static org.mockito.Mockito.when;
|
||||||
|
|
||||||
@@ -15,6 +16,7 @@ import java.util.Map;
|
|||||||
import org.mockito.ArgumentCaptor;
|
import org.mockito.ArgumentCaptor;
|
||||||
import org.junit.jupiter.api.Test;
|
import org.junit.jupiter.api.Test;
|
||||||
import org.springframework.jdbc.core.JdbcTemplate;
|
import org.springframework.jdbc.core.JdbcTemplate;
|
||||||
|
import org.springframework.mock.env.MockEnvironment;
|
||||||
|
|
||||||
import com.dsasp.server.common.workflow.service.ProcessCoreService;
|
import com.dsasp.server.common.workflow.service.ProcessCoreService;
|
||||||
import com.eip4.platform.auth.security.AuthPrincipal;
|
import com.eip4.platform.auth.security.AuthPrincipal;
|
||||||
@@ -35,8 +37,18 @@ class TodoControllerAmisTest {
|
|||||||
private final StatusWriteback statusWriteback = mock(StatusWriteback.class);
|
private final StatusWriteback statusWriteback = mock(StatusWriteback.class);
|
||||||
private final BusinessSummaryService businessSummaryService = mock(BusinessSummaryService.class);
|
private final BusinessSummaryService businessSummaryService = mock(BusinessSummaryService.class);
|
||||||
private final JdbcTemplate jdbcTemplate = mock(JdbcTemplate.class);
|
private final JdbcTemplate jdbcTemplate = mock(JdbcTemplate.class);
|
||||||
|
// 共享控制器走旁路 profile(ci),其余 amis 端点测试不受 P0 脚本守卫影响。
|
||||||
private final TodoController controller = new TodoController(
|
private final TodoController controller = new TodoController(
|
||||||
aggregator, flowableClient, statusWriteback, businessSummaryService, jdbcTemplate);
|
aggregator, flowableClient, statusWriteback, businessSummaryService, jdbcTemplate,
|
||||||
|
new MockEnvironment().withProperty("spring.profiles.active", "ci"));
|
||||||
|
|
||||||
|
/** 构造指定 active profile 的控制器(用于高级脚本端点的 profile 守卫测试)。 */
|
||||||
|
private TodoController controllerWithProfiles(String... profiles) {
|
||||||
|
MockEnvironment env = new MockEnvironment();
|
||||||
|
env.setActiveProfiles(profiles);
|
||||||
|
return new TodoController(aggregator, flowableClient, statusWriteback,
|
||||||
|
businessSummaryService, jdbcTemplate, env);
|
||||||
|
}
|
||||||
|
|
||||||
private static AuthPrincipal principal() {
|
private static AuthPrincipal principal() {
|
||||||
return new AuthPrincipal("U1", "u1", "张三", "D1", "O1", List.of("R1"));
|
return new AuthPrincipal("U1", "u1", "张三", "D1", "O1", List.of("R1"));
|
||||||
@@ -302,4 +314,33 @@ class TodoControllerAmisTest {
|
|||||||
dto.ended = ended;
|
dto.ended = ended;
|
||||||
return dto;
|
return dto;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ───────────────────── P0:高级处理脚本端点 profile 守卫(RCE 防护) ─────────────────────
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void advancedScript_严格profile_拒绝执行且不触达引擎() {
|
||||||
|
TodoController prod = controllerWithProfiles(); // 无 active profile = 严格(prod 同)
|
||||||
|
GatewayRequests.AdvancedScriptRequest req = new GatewayRequests.AdvancedScriptRequest();
|
||||||
|
req.script = "Runtime.getRuntime().exec('id')"; // 攻击载荷
|
||||||
|
|
||||||
|
Map<String, Object> body = prod.runProcessAdvancedScript(principal(), "PI-1", req).getBody();
|
||||||
|
|
||||||
|
assertThat(body.get("status")).as("严格 profile 必须拒绝(amis status=1)").isEqualTo(1);
|
||||||
|
assertThat(String.valueOf(body.get("msg"))).contains("生产");
|
||||||
|
// 关键:守卫在执行/取流程实例之前短路,脚本绝不进引擎
|
||||||
|
verify(flowableClient, never()).processInstance(anyString());
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void advancedScript_旁路profile_放行通过守卫到脚本校验() {
|
||||||
|
TodoController dev = controllerWithProfiles("dev");
|
||||||
|
GatewayRequests.AdvancedScriptRequest req = new GatewayRequests.AdvancedScriptRequest();
|
||||||
|
req.script = " "; // 空脚本:证明已越过 profile 守卫,落到下一道 script 非空校验
|
||||||
|
|
||||||
|
Map<String, Object> body = dev.runProcessAdvancedScript(principal(), "PI-1", req).getBody();
|
||||||
|
|
||||||
|
assertThat(body.get("status")).isEqualTo(1);
|
||||||
|
assertThat(String.valueOf(body.get("msg")))
|
||||||
|
.as("旁路 profile 不被守卫拦截,落到脚本非空校验").contains("请输入高级处理脚本");
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user