feat: add AI render plan gate
This commit is contained in:
@@ -876,7 +876,10 @@ public class AiAgentService {
|
||||
case ENTITY -> gates.add(validateEntityGate(payload));
|
||||
case SERVICEFLOW -> gates.add(validateServiceFlowGate(payload));
|
||||
case MENU -> gates.add(validateMenuGate(payload));
|
||||
case TEST -> gates.add(validateTestGate(payload));
|
||||
case TEST -> {
|
||||
gates.add(validateTestGate(payload));
|
||||
gates.add(validateRenderPlanGate(payload));
|
||||
}
|
||||
case CODE -> gates.add(new AiGateResult("code-review-required", true, List.of("代码草稿需后续静态检查/单测门禁")));
|
||||
}
|
||||
return List.copyOf(gates);
|
||||
@@ -971,6 +974,113 @@ public class AiAgentService {
|
||||
return new AiGateResult("smoke-plan", messages.isEmpty(), messages.stream().limit(20).toList());
|
||||
}
|
||||
|
||||
private AiGateResult validateRenderPlanGate(JsonNode payload) {
|
||||
List<String> messages = new ArrayList<>();
|
||||
JsonNode tests = payload.path("renderTests");
|
||||
if (!tests.isArray() || tests.isEmpty()) {
|
||||
messages.add("renderTests 至少需要 1 条");
|
||||
} else {
|
||||
for (JsonNode test : tests) {
|
||||
String name = test.path("name").asText("");
|
||||
String recipe = test.path("recipe").asText("");
|
||||
String schemaUrl = test.path("schemaUrl").asText("");
|
||||
String rootType = test.path("expectedRootType").asText("");
|
||||
String bodyType = test.path("expectedBodyType").asText("");
|
||||
String crudName = test.path("expectedCrudName").asText("");
|
||||
String expectedApi = test.path("expectedApi").asText("");
|
||||
JsonNode components = test.path("expectedComponents");
|
||||
JsonNode columns = test.path("expectedColumns");
|
||||
JsonNode actions = test.path("expectedActions");
|
||||
JsonNode texts = test.path("expectedTexts");
|
||||
if (name.isBlank()) {
|
||||
messages.add("render name 不能为空");
|
||||
}
|
||||
if (pageRecipeRegistry.find(recipe).isEmpty()) {
|
||||
messages.add("render recipe 未注册: " + recipe);
|
||||
}
|
||||
if (!schemaUrl.startsWith("/api/page/schema/")) {
|
||||
messages.add("render schemaUrl 必须以 /api/page/schema/ 开头: " + schemaUrl);
|
||||
}
|
||||
if (!"page".equals(rootType)) {
|
||||
messages.add("render expectedRootType 必须是 page");
|
||||
}
|
||||
if (!"crud".equals(bodyType)) {
|
||||
messages.add("render expectedBodyType 必须是 crud");
|
||||
}
|
||||
if (crudName.isBlank()) {
|
||||
messages.add("render expectedCrudName 不能为空");
|
||||
}
|
||||
if (!expectedApi.startsWith("/api/entity/")) {
|
||||
messages.add("render expectedApi 必须指向 /api/entity/: " + expectedApi);
|
||||
}
|
||||
if (PageBlueprint.RECIPE_TREE_CRUD.equals(recipe) && !expectedApi.contains("/tree?")) {
|
||||
messages.add("tree-crud-v1 render expectedApi 必须是树接口");
|
||||
}
|
||||
if (PageBlueprint.RECIPE_MAINTENANCE_CRUD.equals(recipe) && !expectedApi.contains("/list?")) {
|
||||
messages.add("maintenance-crud-v1 render expectedApi 必须是列表接口");
|
||||
}
|
||||
if (!components.isArray() || components.isEmpty()) {
|
||||
messages.add("render expectedComponents 至少需要 1 项");
|
||||
} else {
|
||||
if (!arrayContainsText(components, "page")) {
|
||||
messages.add("render expectedComponents 必须包含 page");
|
||||
}
|
||||
if (!arrayContainsText(components, "crud")) {
|
||||
messages.add("render expectedComponents 必须包含 crud");
|
||||
}
|
||||
}
|
||||
if (!columns.isArray() || columns.isEmpty()) {
|
||||
messages.add("render expectedColumns 至少需要 1 项");
|
||||
} else {
|
||||
for (JsonNode column : columns) {
|
||||
if (column.path("name").asText("").isBlank()) {
|
||||
messages.add("render expectedColumns.name 不能为空");
|
||||
}
|
||||
if (column.path("label").asText("").isBlank()) {
|
||||
messages.add("render expectedColumns.label 不能为空");
|
||||
}
|
||||
}
|
||||
}
|
||||
if (!actions.isArray() || actions.isEmpty()) {
|
||||
messages.add("render expectedActions 至少需要 1 项");
|
||||
} else {
|
||||
if (!arrayContainsText(actions, "新增")
|
||||
&& !arrayContainsTextStartingWith(actions, "新增顶级")) {
|
||||
messages.add("render expectedActions 必须包含新增动作");
|
||||
}
|
||||
if (!arrayContainsText(actions, "编辑")) {
|
||||
messages.add("render expectedActions 必须包含编辑动作");
|
||||
}
|
||||
if (!arrayContainsText(actions, "删除")) {
|
||||
messages.add("render expectedActions 必须包含删除动作");
|
||||
}
|
||||
}
|
||||
if (!texts.isArray() || texts.isEmpty()) {
|
||||
messages.add("render expectedTexts 至少需要 1 项");
|
||||
}
|
||||
}
|
||||
}
|
||||
return new AiGateResult("render-plan", messages.isEmpty(), messages.stream().limit(20).toList());
|
||||
}
|
||||
|
||||
private static boolean arrayContainsText(JsonNode array, String value) {
|
||||
for (JsonNode item : array) {
|
||||
if (value.equals(item.asText(""))) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
private static boolean arrayContainsTextStartingWith(JsonNode array, String prefix) {
|
||||
for (JsonNode item : array) {
|
||||
if (item.asText("").startsWith(prefix)) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
private static boolean isValidFlowXml(String xml) {
|
||||
if (xml == null || xml.isBlank()) {
|
||||
return false;
|
||||
|
||||
@@ -141,8 +141,11 @@ public class AiFeatureDraftGenerator {
|
||||
ObjectNode create = addSmoke(tests, "entity-create", "POST",
|
||||
"/api/entity/" + spec.tableName() + "/save", 200);
|
||||
create.set("requestBody", sampleEntityBody(spec));
|
||||
ArrayNode renderTests = root.putArray("renderTests");
|
||||
addRender(renderTests, spec);
|
||||
ArrayNode manual = root.putArray("manualGates");
|
||||
manual.add("确认实体字段、菜单位置、权限角色和服务流写入策略");
|
||||
manual.add("按 renderTests 使用 Playwright 渲染页面,确认组件、列和操作按钮符合 recipe");
|
||||
manual.add("确认本地 smoke 通过后再人工部署线上");
|
||||
return root;
|
||||
}
|
||||
@@ -156,6 +159,71 @@ public class AiFeatureDraftGenerator {
|
||||
return t;
|
||||
}
|
||||
|
||||
private void addRender(ArrayNode renderTests, FeatureSpec spec) {
|
||||
ObjectNode render = renderTests.addObject();
|
||||
render.put("name", "page-render");
|
||||
render.put("recipe", spec.pageRecipe());
|
||||
render.put("schemaUrl", "/api/page/schema/" + spec.templateId());
|
||||
render.put("expectedRootType", "page");
|
||||
render.put("expectedBodyType", "crud");
|
||||
render.put("expectedCrudName", expectedCrudName(spec));
|
||||
render.put("expectedApi", expectedPageApi(spec));
|
||||
if (PageBlueprint.RECIPE_TREE_CRUD.equals(spec.pageRecipe())) {
|
||||
render.put("childrenColumnName", "children");
|
||||
}
|
||||
ArrayNode components = render.putArray("expectedComponents");
|
||||
components.add("page");
|
||||
components.add("crud");
|
||||
components.add("form");
|
||||
components.add("button");
|
||||
addExpectedColumns(render.putArray("expectedColumns"), spec);
|
||||
addExpectedActions(render.putArray("expectedActions"), spec);
|
||||
ArrayNode texts = render.putArray("expectedTexts");
|
||||
texts.add(spec.featureName());
|
||||
texts.add(spec.entityName());
|
||||
for (FieldSpec field : spec.fields()) {
|
||||
if (!"PARENTID".equals(field.column())) {
|
||||
texts.add(field.label());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private void addExpectedColumns(ArrayNode columns, FeatureSpec spec) {
|
||||
for (FieldSpec field : spec.fields()) {
|
||||
if ("PARENTID".equals(field.column())) {
|
||||
continue;
|
||||
}
|
||||
ObjectNode column = columns.addObject();
|
||||
column.put("name", field.column());
|
||||
column.put("label", field.label());
|
||||
}
|
||||
}
|
||||
|
||||
private void addExpectedActions(ArrayNode actions, FeatureSpec spec) {
|
||||
if (PageBlueprint.RECIPE_TREE_CRUD.equals(spec.pageRecipe())) {
|
||||
actions.add("新增顶级" + spec.entityName());
|
||||
actions.add("刷新");
|
||||
actions.add("加子" + spec.entityName());
|
||||
} else {
|
||||
actions.add("新增");
|
||||
}
|
||||
actions.add("编辑");
|
||||
actions.add("删除");
|
||||
}
|
||||
|
||||
private static String expectedCrudName(FeatureSpec spec) {
|
||||
return lowerCamel(spec.tableName())
|
||||
+ (PageBlueprint.RECIPE_TREE_CRUD.equals(spec.pageRecipe()) ? "TreeCrud" : "Crud");
|
||||
}
|
||||
|
||||
private static String expectedPageApi(FeatureSpec spec) {
|
||||
if (PageBlueprint.RECIPE_TREE_CRUD.equals(spec.pageRecipe())) {
|
||||
return "/api/entity/" + spec.tableName()
|
||||
+ "/tree?parentKey=PARENTID&idKey=" + spec.tableName() + "_ID&perPage=2000";
|
||||
}
|
||||
return "/api/entity/" + spec.tableName() + "/list?page=${page}&perPage=${perPage}";
|
||||
}
|
||||
|
||||
private ObjectNode sampleEntityBody(FeatureSpec spec) {
|
||||
ObjectNode body = objectMapper.createObjectNode();
|
||||
for (FieldSpec field : spec.fields()) {
|
||||
@@ -303,6 +371,17 @@ public class AiFeatureDraftGenerator {
|
||||
return metadata;
|
||||
}
|
||||
|
||||
private static String lowerCamel(String table) {
|
||||
String[] parts = table.toLowerCase(Locale.ROOT).split("_+");
|
||||
StringBuilder sb = new StringBuilder(parts[0]);
|
||||
for (int i = 1; i < parts.length; i++) {
|
||||
if (!parts[i].isBlank()) {
|
||||
sb.append(Character.toUpperCase(parts[i].charAt(0))).append(parts[i].substring(1));
|
||||
}
|
||||
}
|
||||
return sb.toString();
|
||||
}
|
||||
|
||||
@SuppressWarnings("unchecked")
|
||||
private Map<String, Object> pageSchemaMetadata(PageBlueprint pageBlueprint) {
|
||||
Map<String, Object> metadata = metadata("page-schema", "sys_page_schema");
|
||||
|
||||
@@ -115,6 +115,64 @@ class AiAgentServiceTest {
|
||||
assertEquals(400, ex.getStatusCode().value());
|
||||
}
|
||||
|
||||
@Test
|
||||
@DisplayName("TEST 草稿必须包含页面渲染计划")
|
||||
void testDraftRequiresRenderPlan() throws Exception {
|
||||
AiAgentService service = newService();
|
||||
var task = service.createTask("验证渲染计划门禁");
|
||||
JsonNode payload = MAPPER.readTree("""
|
||||
{"publishTarget":"local-smoke","smokeTests":[
|
||||
{"name":"page-schema","method":"GET","url":"/api/page/schema/demo","expectHttpStatus":200}
|
||||
]}
|
||||
""");
|
||||
|
||||
var draft = service.addDraft(task.id(), "TEST", "demo-smoke", payload, null);
|
||||
|
||||
assertFalse(draft.passed());
|
||||
assertTrue(draft.gates().stream()
|
||||
.anyMatch(g -> "render-plan".equals(g.name()) && !g.passed()
|
||||
&& g.messages().toString().contains("renderTests")));
|
||||
ResponseStatusException ex = assertThrows(ResponseStatusException.class,
|
||||
() -> service.createChangeSet(task.id()));
|
||||
assertEquals(409, ex.getStatusCode().value());
|
||||
}
|
||||
|
||||
@Test
|
||||
@DisplayName("TEST 渲染计划必须声明列和动作断言")
|
||||
void testDraftRequiresRenderColumnsAndActions() throws Exception {
|
||||
AiAgentService service = newService();
|
||||
var task = service.createTask("验证渲染计划细节门禁");
|
||||
JsonNode payload = MAPPER.readTree("""
|
||||
{
|
||||
"publishTarget":"local-smoke",
|
||||
"smokeTests":[
|
||||
{"name":"page-schema","method":"GET","url":"/api/page/schema/demo","expectHttpStatus":200}
|
||||
],
|
||||
"renderTests":[
|
||||
{
|
||||
"name":"page-render",
|
||||
"recipe":"maintenance-crud-v1",
|
||||
"schemaUrl":"/api/page/schema/demo",
|
||||
"expectedRootType":"page",
|
||||
"expectedBodyType":"crud",
|
||||
"expectedCrudName":"demoCrud",
|
||||
"expectedApi":"/api/entity/EIP4AI_DEMO/list?page=${page}&perPage=${perPage}",
|
||||
"expectedComponents":["page","crud"],
|
||||
"expectedTexts":["示例"]
|
||||
}
|
||||
]
|
||||
}
|
||||
""");
|
||||
|
||||
var draft = service.addDraft(task.id(), "TEST", "demo-smoke", payload, null);
|
||||
|
||||
assertFalse(draft.passed());
|
||||
assertTrue(draft.gates().stream()
|
||||
.anyMatch(g -> "render-plan".equals(g.name()) && !g.passed()
|
||||
&& g.messages().toString().contains("expectedColumns")
|
||||
&& g.messages().toString().contains("expectedActions")));
|
||||
}
|
||||
|
||||
@Test
|
||||
@DisplayName("自动开发功能:生成实体/页面/服务流/菜单/测试草稿并创建待人审变更包")
|
||||
void developFeatureCreatesFullDraftSet() {
|
||||
@@ -374,9 +432,7 @@ class AiAgentServiceTest {
|
||||
""");
|
||||
var pageDraft = service.addDraft(task.id(), "PAGE_SCHEMA", "bad-page", pageWithoutBody, Map.of());
|
||||
assertTrue(pageDraft.passed());
|
||||
JsonNode testPayload = MAPPER.readTree("""
|
||||
{"smokeTests":[{"name":"page-schema","method":"GET","url":"/api/page/schema/bad-page","expectHttpStatus":200}]}
|
||||
""");
|
||||
JsonNode testPayload = testPayload("page-schema", "/api/page/schema/bad-page");
|
||||
service.addDraft(task.id(), "TEST", "bad-page-smoke", testPayload, Map.of());
|
||||
var changeSet = service.createChangeSet(task.id());
|
||||
|
||||
@@ -407,9 +463,7 @@ class AiAgentServiceTest {
|
||||
{"name":"坏菜单","viewTemplateId":"bad-page","typename":"功能菜单","seq":0}
|
||||
""");
|
||||
service.addDraft(task.id(), "MENU", "bad-page", menu, Map.of());
|
||||
JsonNode testPayload = MAPPER.readTree("""
|
||||
{"smokeTests":[{"name":"page-schema","method":"GET","url":"/api/page/schema/bad-page","expectHttpStatus":200}]}
|
||||
""");
|
||||
JsonNode testPayload = testPayload("page-schema", "/api/page/schema/bad-page");
|
||||
service.addDraft(task.id(), "TEST", "bad-page-smoke", testPayload, Map.of());
|
||||
var changeSet = service.createChangeSet(task.id());
|
||||
|
||||
@@ -445,9 +499,7 @@ class AiAgentServiceTest {
|
||||
{"requiresEntityId":true,"flows":[{"key":"EIP4AI_FLOW_FIX_SEARCH","displayName":"查询","entityId":"wrong-entity-id","control":true,"updateable":true,"contentXml":"<flow><input entityid=\\"wrong-entity-id\\"/><transition/></flow>"}]}
|
||||
""");
|
||||
service.addDraft(task.id(), "SERVICEFLOW", "EIP4AI_FLOW_FIX_DEFAULT_FLOWS", serviceFlow, Map.of());
|
||||
JsonNode testPayload = MAPPER.readTree("""
|
||||
{"smokeTests":[{"name":"flow-search","method":"GET","url":"/api/flow/EIP4AI_FLOW_FIX_SEARCH","expectHttpStatus":200}]}
|
||||
""");
|
||||
JsonNode testPayload = testPayload("flow-search", "/api/flow/EIP4AI_FLOW_FIX_SEARCH");
|
||||
service.addDraft(task.id(), "TEST", "flow-fix-smoke", testPayload, Map.of());
|
||||
var changeSet = service.createChangeSet(task.id());
|
||||
|
||||
@@ -478,9 +530,7 @@ class AiAgentServiceTest {
|
||||
{"tablename":"EIP4AI_ENTITY_FIX","name":"实体修复","attributes":[{"column":"NAME","display":"","type":"string","mandatory":true}]}
|
||||
""");
|
||||
service.addDraft(task.id(), "ENTITY", "EIP4AI_ENTITY_FIX", entity, Map.of());
|
||||
JsonNode testPayload = MAPPER.readTree("""
|
||||
{"smokeTests":[{"name":"entity-list","method":"GET","url":"/api/entity/EIP4AI_ENTITY_FIX/list","expectHttpStatus":200}]}
|
||||
""");
|
||||
JsonNode testPayload = testPayload("entity-list", "/api/entity/EIP4AI_ENTITY_FIX/list");
|
||||
service.addDraft(task.id(), "TEST", "entity-fix-smoke", testPayload, Map.of());
|
||||
var changeSet = service.createChangeSet(task.id());
|
||||
|
||||
@@ -521,9 +571,7 @@ class AiAgentServiceTest {
|
||||
{"tablename":"EIP4AI_ENTITY_FIX","name":"实体修复","attributes":[{"column":"NAME","display":"","type":"string","mandatory":true}]}
|
||||
""");
|
||||
service.addDraft(task.id(), "ENTITY", "EIP4AI_ENTITY_FIX", entity, Map.of());
|
||||
JsonNode testPayload = MAPPER.readTree("""
|
||||
{"smokeTests":[{"name":"entity-list","method":"GET","url":"/api/entity/EIP4AI_ENTITY_FIX/list","expectHttpStatus":200}]}
|
||||
""");
|
||||
JsonNode testPayload = testPayload("entity-list", "/api/entity/EIP4AI_ENTITY_FIX/list");
|
||||
service.addDraft(task.id(), "TEST", "entity-fix-smoke", testPayload, Map.of());
|
||||
var changeSet = service.createChangeSet(task.id());
|
||||
service.applyLocalRelease(task.id(), changeSet.id(), "http://localhost:8084");
|
||||
@@ -598,6 +646,31 @@ class AiAgentServiceTest {
|
||||
}
|
||||
}
|
||||
|
||||
private static JsonNode testPayload(String smokeName, String smokeUrl) {
|
||||
return json("""
|
||||
{
|
||||
"smokeTests": [
|
||||
{"name": "%s", "method": "GET", "url": "%s", "expectHttpStatus": 200}
|
||||
],
|
||||
"renderTests": [
|
||||
{
|
||||
"name": "page-render",
|
||||
"recipe": "maintenance-crud-v1",
|
||||
"schemaUrl": "/api/page/schema/test-page",
|
||||
"expectedRootType": "page",
|
||||
"expectedBodyType": "crud",
|
||||
"expectedCrudName": "testPageCrud",
|
||||
"expectedApi": "/api/entity/EIP4AI_TEST/list?page=${page}&perPage=${perPage}",
|
||||
"expectedComponents": ["page", "crud", "form", "button"],
|
||||
"expectedColumns": [{"name": "NAME", "label": "名称"}],
|
||||
"expectedActions": ["新增", "编辑", "删除"],
|
||||
"expectedTexts": ["测试页面"]
|
||||
}
|
||||
]
|
||||
}
|
||||
""".formatted(smokeName, smokeUrl));
|
||||
}
|
||||
|
||||
private static class NoopLocalReleaseExecutor extends AiLocalReleaseExecutor {
|
||||
NoopLocalReleaseExecutor() {
|
||||
super(org.mockito.Mockito.mock(org.springframework.jdbc.core.JdbcTemplate.class),
|
||||
|
||||
@@ -57,6 +57,16 @@ class AiFeatureDraftGeneratorTest {
|
||||
var test = drafts.stream().filter(d -> d.artifactType() == AiArtifactType.TEST)
|
||||
.findFirst().orElseThrow();
|
||||
assertTrue(test.payload().path("smokeTests").get(3).has("requestBody"));
|
||||
assertEquals("maintenance-crud-v1", test.payload().path("renderTests").get(0).path("recipe").asText());
|
||||
assertEquals("/api/page/schema/eip4ai-contract-type",
|
||||
test.payload().path("renderTests").get(0).path("schemaUrl").asText());
|
||||
assertEquals("eip4aiContractTypeCrud",
|
||||
test.payload().path("renderTests").get(0).path("expectedCrudName").asText());
|
||||
assertEquals("NAME", test.payload().path("renderTests").get(0)
|
||||
.path("expectedColumns").get(0).path("name").asText());
|
||||
assertTrue(hasText(test.payload().path("renderTests").get(0).path("expectedActions"), "新增"));
|
||||
assertTrue(hasText(test.payload().path("renderTests").get(0).path("expectedActions"), "编辑"));
|
||||
assertTrue(hasText(test.payload().path("renderTests").get(0).path("expectedActions"), "删除"));
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -116,6 +126,15 @@ class AiFeatureDraftGeneratorTest {
|
||||
assertEquals("/api/entity/EIP4AI_ORG_CATEGORY/tree?parentKey=PARENTID&idKey=EIP4AI_ORG_CATEGORY_ID&perPage=2000",
|
||||
test.payload().path("smokeTests").get(1).path("url").asText());
|
||||
assertEquals("", test.payload().path("smokeTests").get(3).path("requestBody").path("PARENTID").asText());
|
||||
assertEquals("tree-crud-v1", test.payload().path("renderTests").get(0).path("recipe").asText());
|
||||
assertEquals("eip4aiOrgCategoryTreeCrud",
|
||||
test.payload().path("renderTests").get(0).path("expectedCrudName").asText());
|
||||
assertEquals("children", test.payload().path("renderTests").get(0).path("childrenColumnName").asText());
|
||||
assertEquals("/api/entity/EIP4AI_ORG_CATEGORY/tree?parentKey=PARENTID&idKey=EIP4AI_ORG_CATEGORY_ID&perPage=2000",
|
||||
test.payload().path("renderTests").get(0).path("expectedApi").asText());
|
||||
assertTrue(hasText(test.payload().path("renderTests").get(0).path("expectedActions"), "新增顶级组织分类"));
|
||||
assertTrue(hasText(test.payload().path("renderTests").get(0).path("expectedActions"), "刷新"));
|
||||
assertTrue(hasText(test.payload().path("renderTests").get(0).path("expectedActions"), "加子组织分类"));
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -153,4 +172,14 @@ class AiFeatureDraftGeneratorTest {
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
private static boolean hasText(Iterable<?> values, String expected) {
|
||||
for (Object value : values) {
|
||||
if (value instanceof com.fasterxml.jackson.databind.JsonNode node
|
||||
&& expected.equals(node.asText())) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user