fix(modeler): activiti.json 修 Modeler.saveXML 大写元素名(断部署)+真Modeler序列化回归测试
CRITICAL:bpmn-js Modeler.saveXML 把被 activiti.json `extends` 的 bpmn 类型序列化成
PascalCase 元素名(<Process>/<UserTask>/<StartEvent>…),未扩展的 <sequenceFlow>/<endEvent>
仍小写。Flowable 大小写敏感 → <Process> 不被识别为流程,ProcessValidator 报
flowable-process-definition-not-executable,部署完全失败。
根因:moddle 把「被扩展类型」的合并描述符 $pkg 设为**最后一个 trait 的包**(moddle
index.esm.js:577)。activiti 包缺 `xml.tagAlias:"lowerCase"`,故 moddle-xml 写元素名时不做
首字母小写 → PascalCase。且 tagAlias 是**双向**的(也驱动 fromXML 解析),要求自定义元素类型名
用 activiti/camunda 惯例的 PascalCase,否则解析 <activiti:taskListener> 找不到类型而丢弃。
修法(对齐 activiti/camunda-bpmn-moddle 标准):
- activiti.json + flowable.json 加 `"xml": { "tagAlias": "lowerCase" }`;
- 自定义元素类型名改 PascalCase:taskListener→TaskListener / executionListener→ExecutionListener
/ field→Field / formProperty→FormProperty / value→Value / in→In / out→Out(属性 type 引用同步)。
XML 元素名仍小写(tagAlias),故 fixture 与「toContain('activiti:taskListener')」类 XML 断言不变。
- Eip4Panel.tsx:moddle.create/$type 用 'activiti:TaskListener';测试 fake 类型名同步。
为何旧测试没抓到:T1.1/T1.2 只断言 activiti 扩展属性/元素多重集,从不断言基础 BPMN 元素名大小写;
fromXML→toXML 与 create 都走同一 moddle-xml Writer 且都产 PascalCase(本 commit 实证)。
新增 serialization.test.ts(4 例,RED→GREEN):以 BpmnModdle(= Modeler.saveXML 的 moddle 层,
jsdom 跑不动 diagram-js SVG)驱动 fromXML→toXML 与 create→toXML,断言基础元素名全小写、无 PascalCase、
isExecutable 保留、扩展元素/属性不丢;flowable 隔离同验。
serialization 4 + fidelity 12 + Eip4Panel 37;全量 231 单测绿,tsc -b rc=0 + build 干净。
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -513,8 +513,8 @@ describe('Eip4Panel — 扩展属性(长尾 $attrs)', () => {
|
||||
describe('Eip4Panel — 任务监听器(taskListener)', () => {
|
||||
it('增:新监听器写回 extensionElements,并保留已有监听器的 field(引用不动)', async () => {
|
||||
const { modeler, updateProperties, moddle, select } = makeModeler();
|
||||
const fieldObj = moddleEl('activiti:field', { name: 'mailTemplate' });
|
||||
const existing = moddleEl('activiti:taskListener', {
|
||||
const fieldObj = moddleEl('activiti:Field', { name: 'mailTemplate' });
|
||||
const existing = moddleEl('activiti:TaskListener', {
|
||||
event: 'complete',
|
||||
class: 'com.dsasp.server.wf.user.listener.TaskCompleteListener',
|
||||
fields: [fieldObj],
|
||||
@@ -543,14 +543,14 @@ describe('Eip4Panel — 任务监听器(taskListener)', () => {
|
||||
fireEvent.change(screen.getByTestId('eip4-listener-event-0'), { target: { value: 'assignment' } });
|
||||
fireEvent.change(screen.getByTestId('eip4-listener-value-0'), { target: { value: 'com.X.Listener' } });
|
||||
const ext = lastPayload(updateProperties).extensionElements as { values: Array<Record<string, unknown>> };
|
||||
const listener = ext.values.find((v) => v.$type === 'activiti:taskListener')!;
|
||||
const listener = ext.values.find((v) => v.$type === 'activiti:TaskListener')!;
|
||||
expect(listener.event).toBe('assignment');
|
||||
expect(listener.class).toBe('com.X.Listener');
|
||||
});
|
||||
|
||||
it('删:移除唯一监听器 → extensionElements=undefined', async () => {
|
||||
const { modeler, updateProperties, select } = makeModeler();
|
||||
const existing = moddleEl('activiti:taskListener', { event: 'create', class: 'com.X' });
|
||||
const existing = moddleEl('activiti:TaskListener', { event: 'create', class: 'com.X' });
|
||||
render(<Eip4Panel modeler={modeler} />);
|
||||
await select(userTask({ extensionElements: { values: [existing] } }));
|
||||
fireEvent.click(screen.getByTestId('eip4-listener-remove-0'));
|
||||
@@ -569,7 +569,7 @@ describe('Eip4Panel — 任务监听器(taskListener)', () => {
|
||||
});
|
||||
fireEvent.change(screen.getByTestId('eip4-listener-value-0'), { target: { value: '${bean}' } });
|
||||
const ext = lastPayload(updateProperties).extensionElements as { values: Array<Record<string, unknown>> };
|
||||
const listener = ext.values.find((v) => v.$type === 'activiti:taskListener')!;
|
||||
const listener = ext.values.find((v) => v.$type === 'activiti:TaskListener')!;
|
||||
expect(listener.delegateExpression).toBe('${bean}');
|
||||
expect('class' in listener).toBe(false);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user